[LWDM] fix(LIVE-29443): add mobile swap status drawer infrastructure#18864
Open
philipptpunkt wants to merge 1 commit into
Open
[LWDM] fix(LIVE-29443): add mobile swap status drawer infrastructure#18864philipptpunkt wants to merge 1 commit into
philipptpunkt wants to merge 1 commit into
Conversation
This was referenced Jun 23, 2026
This was referenced Jun 23, 2026
live-github-bot
Bot
changed the title
Contributor
Web Tools Build Status
|
philipptpunkt
changed the title
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing Redux + drawer plumbing on Ledger Wallet Mobile to support an upcoming “Swap Transaction Status” bottom-sheet flow, and tightens the queued drawer close handling to reliably distinguish header-close intent from other close causes.
Changes:
- Introduces a new
swapTransactionStatusDrawerRedux slice (open/close + params) and wires it into the mobile root reducer +Statetyping. - Extends the queued drawer bottom-sheet hook/component to handle
onHeaderClosePresseddeterministically (and avoid duplicateonCloseon subsequent dismiss signals). - Updates CODEOWNERS and adds unit coverage for the new header-close behavior in
useQueuedDrawerBottomSheet.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
CODEOWNERS |
Assigns ownership for the new mobile swap status drawer reducer file. |
apps/ledger-live-mobile/src/reducers/types.ts |
Adds the new slice type/import and includes it in the root State. |
apps/ledger-live-mobile/src/reducers/swapTransactionStatusDrawer.ts |
New Redux Toolkit slice storing drawer open state + SwapTransactionStatusParams. |
apps/ledger-live-mobile/src/reducers/index.ts |
Registers the new reducer in combineReducers. |
apps/ledger-live-mobile/src/mvvm/components/QueuedDrawer/useQueuedDrawerBottomSheet.ts |
Adds onHeaderClosePressed support with guarded close sequencing. |
apps/ledger-live-mobile/src/mvvm/components/QueuedDrawer/QueuedDrawerBottomSheet.tsx |
Routes BottomSheet onHeaderClosePressed through the hook handler. |
apps/ledger-live-mobile/src/mvvm/components/QueuedDrawer/__tests__/useQueuedDrawerBottomSheet.test.ts |
Adds a regression test ensuring header-close triggers callbacks once and ignores later close events. |
Contributor
Rsdoctor Bundle Diff AnalysisFound 7 projects in monorepo, 7 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 desktop-mainPath:
📁 desktop-preloaderPath:
📁 desktop-rendererPath:
📁 desktop-webviewDappPreloaderPath:
📁 desktop-webviewPreloaderPath:
📁 desktop-workersPath:
📁 mobilePath:
Generated by Rsdoctor GitHub Action |
philipptpunkt
force-pushed
the
feat/LIVE-29443-swap-status-desktop
branch
from
73fa0e9 to
3c63647
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-mobile-swap-status-infra
branch
from
f4c4d45 to
75488d4
Compare
Justkant
previously approved these changes
Jun 23, 2026
philipptpunkt
force-pushed
the
feat/LIVE-29443-swap-status-desktop
branch
from
3c63647 to
ddad409
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-mobile-swap-status-infra
branch
from
75488d4 to
7eadb5a
Compare
Contributor
philipptpunkt
force-pushed
the
feat/LIVE-29443-swap-status-desktop
branch
from
ddad409 to
df27b3c
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-mobile-swap-status-infra
branch
from
7eadb5a to
9138418
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-swap-status-desktop
branch
from
df27b3c to
5eddc1c
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-mobile-swap-status-infra
branch
from
9138418 to
73350df
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-swap-status-desktop
branch
from
5eddc1c to
e60054b
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-mobile-swap-status-infra
branch
from
73350df to
904dc9d
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-mobile-swap-status-infra
branch
from
904dc9d to
df1604f
Compare
philipptpunkt
force-pushed
the
feat/LIVE-29443-mobile-swap-status-infra
branch
from
df1604f to
a4f9955
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://ledgerhq.atlassian.net/browse/LIVE-29443
Summary
swapTransactionStatusDrawerreducer and root reducer/type registration.handleHeaderClosePressedso close tracking and duplicate close protection remain stable.Review Scope
@ledgerhq/wallet-xpfor genericQueuedDrawerbehavior.@ledgerhq/ptxfor the swap status drawer reducer ownership.Validation
QueuedDrawerfocused Jest tests passed.Stack (managed by stac-man)